Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 19875002: Adds reciprocal squre root SIMD instructions for ARM. (Closed)

Created:
7 years, 5 months ago by zra
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adds reciprocal squre root SIMD instructions for ARM. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25291

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -9 lines) Patch
M runtime/vm/assembler_arm.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 3 chunks +278 lines, -1 line 0 comments Download
M runtime/vm/constants_arm.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 5 chunks +72 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zra
7 years, 5 months ago (2013-07-19 23:49:56 UTC) #1
regis
LGTM Just curious regarding the change to get_qregister(): was there a compiler issue with returning ...
7 years, 5 months ago (2013-07-22 16:02:53 UTC) #2
zra
On 2013/07/22 16:02:53, regis wrote: > LGTM > > Just curious regarding the change to ...
7 years, 5 months ago (2013-07-22 16:33:14 UTC) #3
regis
On 2013/07/22 16:33:14, zra wrote: > On 2013/07/22 16:02:53, regis wrote: > > LGTM > ...
7 years, 5 months ago (2013-07-22 16:41:06 UTC) #4
zra
7 years, 5 months ago (2013-07-22 18:19:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r25291 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698