Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 198723006: Add archiving of src tarball and debian packages (Closed)

Created:
6 years, 9 months ago by ricow1
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add archiving of src tarball and debian packages R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34155

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -11 lines) Patch
M tools/bots/bot_utils.py View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M tools/bots/src-tarball.py View 1 2 3 chunks +38 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ricow1
6 years, 9 months ago (2014-03-17 15:19:37 UTC) #1
ricow1
https://codereview.chromium.org/198723006/diff/1/tools/bots/src-tarball.py File tools/bots/src-tarball.py (right): https://codereview.chromium.org/198723006/diff/1/tools/bots/src-tarball.py#newcode61 tools/bots/src-tarball.py:61: version = utils.GetVersion() this block is just moved out ...
6 years, 9 months ago (2014-03-17 15:20:24 UTC) #2
Søren Gjesse
https://codereview.chromium.org/198723006/diff/20001/tools/bots/bot_utils.py File tools/bots/bot_utils.py (right): https://codereview.chromium.org/198723006/diff/20001/tools/bots/bot_utils.py#newcode139 tools/bots/bot_utils.py:139: return self._variant_directory('linux_packages', revision) ubuntu_precise_packages? For the Debian chroot builds ...
6 years, 9 months ago (2014-03-17 18:07:34 UTC) #3
ricow1
https://codereview.chromium.org/198723006/diff/20001/tools/bots/bot_utils.py File tools/bots/bot_utils.py (right): https://codereview.chromium.org/198723006/diff/20001/tools/bots/bot_utils.py#newcode139 tools/bots/bot_utils.py:139: return self._variant_directory('linux_packages', revision) On 2014/03/17 18:07:35, Søren Gjesse wrote: ...
6 years, 9 months ago (2014-03-17 18:24:47 UTC) #4
Søren Gjesse
https://codereview.chromium.org/198723006/diff/20001/tools/bots/bot_utils.py File tools/bots/bot_utils.py (right): https://codereview.chromium.org/198723006/diff/20001/tools/bots/bot_utils.py#newcode139 tools/bots/bot_utils.py:139: return self._variant_directory('linux_packages', revision) On 2014/03/17 18:24:47, ricow1 wrote: > ...
6 years, 9 months ago (2014-03-18 11:43:41 UTC) #5
ricow1
sounds good to me, I changed it now to get a linux system from the ...
6 years, 9 months ago (2014-03-18 14:27:42 UTC) #6
Søren Gjesse
lgtm
6 years, 9 months ago (2014-03-18 14:55:28 UTC) #7
ricow1
6 years, 9 months ago (2014-03-20 07:41:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r34155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698