Inline create parameter mirror list functionality.

Inline CreateParameterMirrorList() functionality.

BUG=
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25450

[Michael Lippautz (Google), 2013-07-23 18:41:46]

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:239: const intptr_t param_cnt =
func.num_fixed_parameters() -
num_fixed_parameters() includes the implicit ones (which we don't want).

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:254: param ^=
CreateMirror(Symbols::_LocalParameterMirrorImpl(), args);
This looks up the class each time it is invoked (library is cached). For now we
consider this as acceptable.

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:266: Dart_EnterScope();
Right now the parameter list is created eagerly when a method mirror is created
(changing soon). Since method mirrors might be populated from creating a mirror
system, we avoid producing too much garbage by entering a temporary scope.

[siva, 2013-07-23 21:44:57]

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:250: args.SetAt(0, reflectee);
This line can be hoisted out of the loop.

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:269: Dart_ExitScope();
why do you need a Dart_EnterScope() / Dart_ExitScope() here?

https://codereview.chromium.org/19856003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/19856003/diff/1/runtime/vm/object.cc#newcode1...
runtime/vm/object.cc:14359: return ref.raw();
It seems heavy weight to add another New method just to be able to set the
referent here, Are you anticipating more fields?

[Michael Lippautz (Google), 2013-07-23 23:18:13]

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:250: args.SetAt(0, reflectee);
On 2013/07/23 21:44:58, siva wrote:
> This line can be hoisted out of the loop.

Done.

https://codereview.chromium.org/19856003/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:269: Dart_ExitScope();
On 2013/07/23 21:44:58, siva wrote:
> why do you need a Dart_EnterScope() / Dart_ExitScope() here?

As discussed offline, we rather use a HANDLESCOPE in the native method isntead.

https://codereview.chromium.org/19856003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/19856003/diff/1/runtime/vm/object.cc#newcode1...
runtime/vm/object.cc:14359: return ref.raw();
On 2013/07/23 21:44:58, siva wrote:
> It seems heavy weight to add another New method just to be able to set the
> referent here, Are you anticipating more fields?

We will make this the default for creating a MirrorReference, since every
MirrorReference must have a referent.

[Michael Lippautz (Google), 2013-07-24 00:55:10]

For some reason not all changes made it into the patch 2. Everything should be
in now.

[siva, 2013-07-24 23:12:38]

lgtm

https://codereview.chromium.org/19856003/diff/9001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/19856003/diff/9001/runtime/lib/mirrors.cc#new...
runtime/lib/mirrors.cc:247: for (intptr_t i = 0; i < param_cnt; ++i) {
normally i++ is used in our code base I think.

[Michael Lippautz (Google), 2013-07-24 23:34:03]

https://codereview.chromium.org/19856003/diff/9001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/19856003/diff/9001/runtime/lib/mirrors.cc#new...
runtime/lib/mirrors.cc:247: for (intptr_t i = 0; i < param_cnt; ++i) {
On 2013/07/24 23:12:38, siva wrote:
> normally i++ is used in our code base I think.

Done.

[Michael Lippautz (Google), 2013-07-24 23:35:21]

Committed patchset #4 manually as r25450 (presubmit successful).