Issue 19853002: Only Firefox needs the vendor prefix. All other browsers have both (webkit browsers) or the unprefi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19853002: Only Firefox needs the vendor prefix. All other browsers have both (webkit browsers) or the unprefi… (Closed)

Created:
7 years, 5 months ago by Emily Fortuna

Modified:
7 years, 5 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Only Firefox needs the vendor prefix. All other browsers have both (webkit browsers) or the unprefixed (IE). BUG= Committed: https://code.google.com/p/dart/source/detail?r=25243

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -9 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate	View	1 chunk	+8 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Committed patchset #1 manually as r25243 (presubmit successful).

7 years, 5 months ago (2013-07-19 20:50:24 UTC) #2

Jennifer Messerly

7 years, 5 months ago (2013-07-19 21:09:20 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/19853002/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
(right):

https://codereview.chromium.org/19853002/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate:927: if
(Device.isFirefox) {
presumably Firefox will implement this natively someday, and Dart code compiled
now would be broken. Perhaps the logic should get/set both properties?

Expand Messages | Collapse Messages