- Make ports be less predictable.

- Make ports be less predictable.

Committed as r 34209.

[turnidge, 2014-03-20 20:28:57]

lgtm w/ comments

Make sure you run all tests (not just vm tests) to catch any tests that rely on
the current port number scheme.

https://codereview.chromium.org/198463007/diff/1/runtime/vm/message_handler.cc
File runtime/vm/message_handler.cc (right):

https://codereview.chromium.org/198463007/diff/1/runtime/vm/message_handler.c...
runtime/vm/message_handler.cc:255: "\tports:      %" Pd"/%" Pd "\n",
consider tagging control and live like this:
               "\tports:      control(%" Pd")/live(%" Pd ")\n",

[kasperl, 2014-03-26 11:39:02]

https://codereview.chromium.org/198463007/diff/1/runtime/vm/port.cc
File runtime/vm/port.cc (right):

https://codereview.chromium.org/198463007/diff/1/runtime/vm/port.cc#newcode68
runtime/vm/port.cc:68: while ((result == 0) && (FindPort(result) >= 0)) {
Shouldn't this be ||? Otherwise, you'll just get the first non-zero result --
even when FindPort(result) would report that the port is in use?

[kasperl, 2014-03-26 12:52:35]

This change seems to have broken the x64 build by making command-line apps run
from within the editor hang every now and then. See issue 17806.

I've reverted this in r34420.

[hausner, 2014-03-28 23:13:20]

LGTM

https://codereview.chromium.org/198463007/diff/1/runtime/vm/port.cc
File runtime/vm/port.cc (right):

https://codereview.chromium.org/198463007/diff/1/runtime/vm/port.cc#newcode68
runtime/vm/port.cc:68: while ((result == 0) && (FindPort(result) >= 0)) {
What Kasper says. And you could turn this into a do { } while() loop.