Issue 19841002: Remove calls to [new Future] work around issue 11911.

Issue 19841002: Remove calls to [new Future] work around issue 11911. (Closed)

Created:
7 years, 5 months ago by nweiz

Modified:
7 years, 5 months ago

Reviewers:
Bob Nystrom, gram

CC:
reviews_dartlang.org, gram, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove calls to [new Future] work around issue 11911. BUG=11911 R=gram@google.com, rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25365

Patch Set 2 : Code review change. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -10 lines)			Patch
M	pkg/barback/lib/src/asset_cascade.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/lib/src/transform.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/utils.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/barback/test/utils.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/lib/src/test_case.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/source/hosted.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/error_group_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Barback and pub changes LGTM. You should add gram for unittest and Florian to see ...

7 years, 5 months ago (2013-07-19 19:54:20 UTC) #2

nweiz

https://codereview.chromium.org/19841002/diff/1/pkg/barback/lib/src/utils.dart File pkg/barback/lib/src/utils.dart (right): https://codereview.chromium.org/19841002/diff/1/pkg/barback/lib/src/utils.dart#newcode104 pkg/barback/lib/src/utils.dart:104: /// Like [new Future], but avoids around issue 11911 ...

7 years, 5 months ago (2013-07-19 20:15:17 UTC) #3

nweiz

Committed patchset #2 manually as r25365 (presubmit successful).

7 years, 5 months ago (2013-07-23 20:26:11 UTC) #6

kevmoo-old

On 2013/07/23 20:26:11, nweiz wrote: > Committed patchset #2 manually as r25365 (presubmit successful). Notice ...

7 years, 5 months ago (2013-07-23 20:49:02 UTC) #7

kevmoo-old

7 years, 5 months ago (2013-07-23 21:38:25 UTC) #8

Message was sent while issue was closed.

On 2013/07/23 20:49:02, kevmoo wrote:
> On 2013/07/23 20:26:11, nweiz wrote:
> > Committed patchset #2 manually as r25365 (presubmit successful).
> 
> Notice some find-replace weridness here?
> 
> "newFuture", etc?

Finished reading the file. Never mind. :-/

Expand Messages | Collapse Messages