Issue 19820007: Fixes for Blink roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19820007: Fixes for Blink roll. (Closed)

Created:
7 years, 5 months ago by vsm

Modified:
7 years, 5 months ago

Reviewers:
siva, Jacob

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes for Blink roll. TBR=jacobr@google.com,asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25395

Patch Set 1 #

Patch Set 2 : Minors fixes #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+218 lines, -126 lines)			Patch
M	tests/html/exceptions_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/worker_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/dom/dom.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View	4 chunks	+10 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/dartgenerator.py	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	3 chunks	+13 lines, -13 lines	0 comments	Download
M	tools/dom/scripts/database.py	View	2 chunks	+32 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/databasebuilder.py	View	5 chunks	+7 lines, -5 lines	0 comments	Download
M	tools/dom/scripts/fremontcutbuilder.py	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	8 chunks	+20 lines, -5 lines	1 comment	Download
M	tools/dom/scripts/htmldartgenerator.py	View	3 chunks	+6 lines, -35 lines	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	1 chunk	+11 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	10 chunks	+39 lines, -29 lines	0 comments	Download
M	tools/dom/scripts/idlparser.py	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	8 chunks	+39 lines, -13 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	tools/dom/templates/html/dartium/cpp_header.template	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/cpp_implementation.template	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

Committed patchset #2 manually as r25395 (presubmit successful).

7 years, 5 months ago (2013-07-24 04:46:40 UTC) #1

Jacob

7 years, 5 months ago (2013-07-24 16:12:00 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/19820007/diff/2001/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/19820007/diff/2001/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:27: #'SubtleCrypto',
remove commented out class names or add comments on why they are removed

Expand Messages | Collapse Messages