Issue 19819003: Make reflective invocations raise NoSuchMethodErrors in the cases where non-reflective invocations …

Issue 19819003: Make reflective invocations raise NoSuchMethodErrors in the cases where non-reflective invocations … (Closed)

Created:
7 years, 5 months ago by rmacnak

Modified:
7 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, ahe, Michael Lippautz (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make reflective invocations raise NoSuchMethodErrors in the cases where non-reflective invocations do so. Resolves issues 11187 and 11957. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25387

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -124 lines)			Patch
M	runtime/lib/errors_patch.dart	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	runtime/lib/mirrors.cc	View	1	10 chunks	+125 lines, -114 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/tests/vm/dart/isolate_mirror_local_test.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/19819003/diff/3001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/19819003/diff/3001/runtime/lib/mirrors.cc#newcode1451 runtime/lib/mirrors.cc:1451: array.SetAt(i, String::Handle(function.ParameterNameAt(i))); String::Handle() outside the loop. https://codereview.chromium.org/19819003/diff/3001/runtime/lib/mirrors.cc#newcode1486 runtime/lib/mirrors.cc:1486: ...

7 years, 5 months ago (2013-07-24 00:06:52 UTC) #2

rmacnak

https://codereview.chromium.org/19819003/diff/3001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/19819003/diff/3001/runtime/lib/mirrors.cc#newcode1451 runtime/lib/mirrors.cc:1451: array.SetAt(i, String::Handle(function.ParameterNameAt(i))); On 2013/07/24 00:06:52, siva wrote: > String::Handle() ...

7 years, 5 months ago (2013-07-24 00:25:49 UTC) #3

rmacnak

7 years, 5 months ago (2013-07-24 00:29:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25387 (presubmit successful).

Expand Messages | Collapse Messages