Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1981283006: Fix a bug with the implementation of LiveSuite. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a bug with the implementation of LiveSuite. We weren't notifying the controller when all the live tests had been added to the suite. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/d1aeae7b93a62cfba5c895a882b3e1eb472c6c4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/runner/engine.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 7 months ago (2016-05-17 22:48:56 UTC) #1
kevmoo
lgtm
4 years, 7 months ago (2016-05-17 22:53:09 UTC) #2
nweiz
4 years, 7 months ago (2016-05-17 22:55:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1aeae7b93a62cfba5c895a882b3e1eb472c6c4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698