Issue 19811002: Do not emit substitutions for unnamed mixin applications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19811002: Do not emit substitutions for unnamed mixin applications. (Closed)

Created:
7 years, 5 months ago by karlklose

Modified:
7 years, 4 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Do not emit substitutions for unnamed mixin applications. Unnamed mixin applications do not hold the type variables that would be required in the substitution. Since a substitution can never be called on them directly, emit the substitutions on the class that mixes them in. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=25919

Patch Set 1 #

Patch Set 2 : Restore removed line breaks. #

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -19 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart	View	1 2	1 chunk	+5 lines, -7 lines	0 comments	Download
A +	tests/language/mixin_type_parameter4_test.dart	View		1 chunk	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

7 years, 4 months ago (2013-08-08 08:49:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r25919 (presubmit successful).

Expand Messages | Collapse Messages