Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 198103004: Remove Dart_AddGcPrologueCallback and Dart_RemoveGcPrologueCallback from the Dart API. (Closed)

Created:
6 years, 9 months ago by siva
Modified:
6 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove Dart_AddGcPrologueCallback and Dart_RemoveGcPrologueCallback from the Dart API. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -183 lines) Patch
M runtime/include/dart_api.h View 1 chunk +0 lines, -51 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 2 chunks +1 line, -70 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
6 years, 9 months ago (2014-03-13 00:06:36 UTC) #1
Ivan Posva
LGTM -ip
6 years, 9 months ago (2014-03-13 08:13:28 UTC) #2
siva
6 years, 9 months ago (2014-03-13 18:10:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33657 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698