Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 19795006: dart2js has its own snapshot. (Closed)

Created:
7 years, 5 months ago by ahe
Modified:
7 years, 5 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, ricow1, kustermann, kasperl, Mads Ager (google)
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removed extra argument. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M dart/dart.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M dart/sdk/bin/dart2js View 1 2 chunks +2 lines, -3 lines 0 comments Download
M dart/sdk/bin/dart2js.bat View 1 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
M dart/utils/compiler/compiler.gyp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
dartdoc is somehow very large. The combined snapshot of dart2js and dartdoc is 70% larger ...
7 years, 5 months ago (2013-07-23 14:14:22 UTC) #1
ngeoffray
LGTM
7 years, 5 months ago (2013-07-23 14:37:42 UTC) #2
ahe
7 years, 5 months ago (2013-07-23 14:58:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25344 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698