Issue 19793008: Stop working around issue 4155 in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19793008: Stop working around issue 4155 in pub. (Closed)

Created:
7 years, 5 months ago by nweiz

Modified:
7 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stop working around issue 4155 in pub. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25303

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	sdk/lib/_internal/pub/test/test_pub.dart	View		1 chunk	+2 lines, -5 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion but LGTM. https://codereview.chromium.org/19793008/diff/1/sdk/lib/_internal/pub/test/test_pub.dart File sdk/lib/_internal/pub/test/test_pub.dart (right): https://codereview.chromium.org/19793008/diff/1/sdk/lib/_internal/pub/test/test_pub.dart#newcode140 sdk/lib/_internal/pub/test/test_pub.dart:140: var future = _server.close(); How ...

7 years, 5 months ago (2013-07-22 21:02:50 UTC) #2

nweiz

https://codereview.chromium.org/19793008/diff/1/sdk/lib/_internal/pub/test/test_pub.dart File sdk/lib/_internal/pub/test/test_pub.dart (right): https://codereview.chromium.org/19793008/diff/1/sdk/lib/_internal/pub/test/test_pub.dart#newcode140 sdk/lib/_internal/pub/test/test_pub.dart:140: var future = _server.close(); On 2013/07/22 21:02:51, Bob Nystrom ...

7 years, 5 months ago (2013-07-22 21:03:48 UTC) #3

nweiz

7 years, 5 months ago (2013-07-22 21:04:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r25303 (presubmit successful).

Expand Messages | Collapse Messages