Issue 197923003: Stop/restart compilation timer when running Dart code from within the parser. SMall perfromance fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197923003: Stop/restart compilation timer when running Dart code from within the parser. SMall perfromance fix. (Closed)

Created:
6 years, 9 months ago by srdjan

Modified:
6 years, 9 months ago

Reviewers:
Cutch, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, hausner

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Stop/restart compilation timer when running Dart code from within the parser. SMall perfromance fix. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33616

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

On 2014/03/12 21:02:32, Cutch wrote: > lgtm Reverted parser change, as it crashes (nested compilation).

6 years, 9 months ago (2014-03-12 21:17:17 UTC) #3

srdjan

Committed patchset #2 manually as r33616 (presubmit successful).

6 years, 9 months ago (2014-03-12 21:28:53 UTC) #4

hausner

6 years, 9 months ago (2014-03-13 07:41:17 UTC) #5

Message was sent while issue was closed.

DBC

Do we even do the right thing when compilation is invoked recursively? Looking
at this it seems the timer is turned off when the innermost compilation stops,
not when the outermost compilation stops.

Expand Messages | Collapse Messages