Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 19789017: Regenerate dart:html from new Blink IDL files (Closed)

Created:
7 years, 5 months ago by vsm
Modified:
7 years, 5 months ago
Reviewers:
Emily Fortuna, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Regenerate dart:html from new Blink IDL files This includes some script updates. See: https://codereview.chromium.org/19605006 for the IDL roll. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=25456

Patch Set 1 #

Total comments: 20

Patch Set 2 : Fixups in dom.json #

Total comments: 6

Patch Set 3 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2536 lines, -1824 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 65 chunks +543 lines, -290 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 84 chunks +874 lines, -516 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 3 chunks +5 lines, -16 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 3 chunks +5 lines, -14 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 24 chunks +33 lines, -71 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 24 chunks +31 lines, -74 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 1 chunk +73 lines, -73 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 1 chunk +72 lines, -72 lines 0 comments Download
M tools/dom/dom.json View 1 2 40 chunks +868 lines, -654 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/fremontcutbuilder.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 2 5 chunks +4 lines, -7 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 5 chunks +27 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vsm
7 years, 5 months ago (2013-07-24 18:55:25 UTC) #1
Emily Fortuna
https://chromiumcodereview.appspot.com/19789017/diff/1/tools/dom/dom.json File tools/dom/dom.json (right): https://chromiumcodereview.appspot.com/19789017/diff/1/tools/dom/dom.json#newcode43 tools/dom/dom.json:43: "AnimationEvent": { Rename to WebkitAnimationEvent and remove the entry ...
7 years, 5 months ago (2013-07-24 21:04:45 UTC) #2
vsm
PTAL https://codereview.chromium.org/19789017/diff/1/tools/dom/dom.json File tools/dom/dom.json (right): https://codereview.chromium.org/19789017/diff/1/tools/dom/dom.json#newcode43 tools/dom/dom.json:43: "AnimationEvent": { On 2013/07/24 21:04:45, Emily Fortuna wrote: ...
7 years, 5 months ago (2013-07-24 22:01:07 UTC) #3
Emily Fortuna
just a few more adjustments https://codereview.chromium.org/19789017/diff/5001/tools/dom/dom.json File tools/dom/dom.json (right): https://codereview.chromium.org/19789017/diff/5001/tools/dom/dom.json#newcode1087 tools/dom/dom.json:1087: "DOMException": { transfer annotations ...
7 years, 5 months ago (2013-07-24 22:37:25 UTC) #4
vsm
PTAL https://chromiumcodereview.appspot.com/19789017/diff/5001/tools/dom/dom.json File tools/dom/dom.json (right): https://chromiumcodereview.appspot.com/19789017/diff/5001/tools/dom/dom.json#newcode1087 tools/dom/dom.json:1087: "DOMException": { On 2013/07/24 22:37:25, Emily Fortuna wrote: ...
7 years, 5 months ago (2013-07-25 00:06:30 UTC) #5
Emily Fortuna
lgtm!
7 years, 5 months ago (2013-07-25 00:07:36 UTC) #6
vsm
7 years, 5 months ago (2013-07-25 00:09:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r25456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698