Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 19789015: TBR: Change BaseMatcher to Matcher in pub test file. (Closed)

Created:
7 years, 5 months ago by gram
Modified:
7 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

TBR: Change BaseMatcher to Matcher in pub test file. Committed: https://code.google.com/p/dart/source/detail?r=25357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/_internal/pub/test/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
Committed patchset #1 manually as r25357 (presubmit successful).
7 years, 5 months ago (2013-07-23 19:58:34 UTC) #1
gram
BaseMatcher has gone away.
7 years, 5 months ago (2013-07-23 19:59:03 UTC) #2
Bob Nystrom
7 years, 5 months ago (2013-07-23 20:10:20 UTC) #3
Message was sent while issue was closed.
LGTM. What's the context for this?

Powered by Google App Engine
This is Rietveld 408576698