Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 197873028: Implement isolate view page. (Closed)

Created:
6 years, 9 months ago by turnidge
Modified:
6 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : minor edits #

Patch Set 3 : tweak html / gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1331 lines, -628 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 5 chunks +161 lines, -10 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 162 chunks +400 lines, -290 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 5 chunks +161 lines, -10 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 162 chunks +400 lines, -290 lines 0 comments Download
M runtime/bin/vmservice/client/lib/elements.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/lib/elements.html View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/app/location_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/bin/vmservice/client/lib/src/elements/isolate_ref.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/elements/isolate_ref.html View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html View 1 2 3 chunks +3 lines, -9 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart View 1 chunk +8 lines, -8 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/elements/isolate_view.html View 1 2 1 chunk +163 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/nav_bar.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
6 years, 9 months ago (2014-03-17 21:07:45 UTC) #1
Cutch
lgtm
6 years, 9 months ago (2014-03-18 14:57:40 UTC) #2
turnidge
6 years, 9 months ago (2014-03-18 16:24:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r33812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698