Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 19786006: - Change the test for ambiguous definitions to be a (Closed)

Created:
7 years, 5 months ago by Ivan Posva
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Change the test for ambiguous definitions to be a multi-test from a negative test. - Add different combinations of ambiguity. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M tests/language/library1.dart View 1 chunk +10 lines, -0 lines 0 comments Download
D tests/language/library1_negative_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M tests/language/library2.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A + tests/language/library_ambiguous_test.dart View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
7 years, 5 months ago (2013-07-19 17:34:58 UTC) #1
regis
LGTM
7 years, 5 months ago (2013-07-19 17:51:44 UTC) #2
Ivan Posva
7 years, 5 months ago (2013-07-19 17:52:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698