Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 19786005: Reapply Box Model convenience classes (Closed)

Created:
7 years, 5 months ago by Emily Fortuna
Modified:
7 years, 5 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply Box Model convenience classes BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=25235

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1895 lines, -114 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 9 chunks +542 lines, -38 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 9 chunks +542 lines, -38 lines 0 comments Download
A tests/html/element_dimensions_test.dart View 1 chunk +263 lines, -0 lines 0 comments Download
A tools/dom/src/CssRectangle.dart View 1 1 chunk +261 lines, -0 lines 0 comments Download
A tools/dom/src/Dimension.dart View 1 chunk +83 lines, -0 lines 0 comments Download
M tools/dom/src/Rectangle.dart View 1 2 chunks +51 lines, -31 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 5 chunks +147 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
The first patch is the version that was checked in yesterday. Patchset 2 is what ...
7 years, 5 months ago (2013-07-19 19:42:51 UTC) #1
Jennifer Messerly
lgtm
7 years, 5 months ago (2013-07-19 19:45:09 UTC) #2
Emily Fortuna
7 years, 5 months ago (2013-07-19 19:46:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698