Cleanup in the type inferrer.

Cleanup in the type inferrer.

- Simplify inferencing of boxed variables. They are now inferred the same way as fields.
- Move the code to handle field initialization into its own class.
- Only track field initializations in generative constructors.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25338

[ahe, 2013-07-23 09:52:13]

lgtm

https://codereview.chromium.org/19784005/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart
(right):

https://codereview.chromium.org/19784005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart:239:
toRemove.forEach((Element element) { fields.remove(element); });
Alternatively, model them as two different types.

https://codereview.chromium.org/19784005/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/19784005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:256:
T typeOfSelector(Selector selector);
Perhaps the name of this method should include the word "return". 

Arguably, the type of a selector is a function type.

[ngeoffray, 2013-07-23 09:57:29]

Thanks Peter

https://codereview.chromium.org/19784005/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart
(right):

https://codereview.chromium.org/19784005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart:239:
toRemove.forEach((Element element) { fields.remove(element); });
On 2013/07/23 09:52:13, ahe wrote:
> Alternatively, model them as two different types. 

I don't understand this comment. Who's them? And what types?

https://codereview.chromium.org/19784005/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/19784005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:256:
T typeOfSelector(Selector selector);
On 2013/07/23 09:52:13, ahe wrote:
> Perhaps the name of this method should include the word "return". 
> 
> Arguably, the type of a selector is a function type. 

Done.

[ngeoffray, 2013-07-23 10:59:25]

Committed patchset #3 manually as r25338 (presubmit successful).