Issue 19779006: Enables more SIMD tests for ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19779006: Enables more SIMD tests for ARM. (Closed)

Created:
7 years, 5 months ago by zra

Modified:
7 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, Cutch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enables more SIMD tests for ARM. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25219

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -31 lines)			Patch
M	runtime/vm/intermediate_language_arm.cc	View	3 chunks	+113 lines, -9 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+0 lines, -2 lines	1 comment	Download
M	tests/lib/typed_data/float32x4_list_test.dart	View	4 chunks	+12 lines, -12 lines	0 comments	Download
M	tests/lib/typed_data/float32x4_unbox_regress_test.dart	View	8 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM You can go home now. https://codereview.chromium.org/19779006/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/19779006/diff/1/tests/lib/lib.status#newcode110 tests/lib/lib.status:110: typed_data/float32x4_test: Crash # ...

7 years, 5 months ago (2013-07-18 23:23:09 UTC) #2

zra

7 years, 5 months ago (2013-07-19 15:29:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25219 (presubmit successful).

Expand Messages | Collapse Messages