Issue 19775015: Fixed bug in _ControllerStream.operator==.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19775015: Fixed bug in _ControllerStream.operator==. (Closed)

Created:
7 years, 5 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed bug in _ControllerStream.operator==. Make _BroacastStream extends _ControllerStream to get same equality behavior. Add regression tests. BUG= http://dartbug.com/11904 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=25205

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -12 lines)			Patch
M	sdk/lib/async/broadcast_stream_controller.dart	View	1 chunk	+2 lines, -11 lines	0 comments	Download
M	sdk/lib/async/stream_controller.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/lib/async/stream_controller_test.dart	View	1 chunk	+21 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/19775015/diff/1/tests/lib/async/stream_controller_test.dart File tests/lib/async/stream_controller_test.dart (right): https://codereview.chromium.org/19775015/diff/1/tests/lib/async/stream_controller_test.dart#newcode435 tests/lib/async/stream_controller_test.dart:435: c = new StreamController.broadcast(sync: true, onListen:(){}); maybe add ...

7 years, 5 months ago (2013-07-19 11:47:39 UTC) #2

Lasse Reichstein Nielsen

7 years, 5 months ago (2013-07-19 11:58:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25205 (presubmit successful).

Expand Messages | Collapse Messages