Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19774007: Collect both arguments for math's min/max static functions. Later that information will be used to … (Closed)

Created:
7 years, 5 months ago by srdjan
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Collect both arguments for math's min/max static functions. Later that information will be used to inline the operation if possible. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25225

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -190 lines) Patch
M runtime/vm/code_generator.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
M runtime/vm/code_patcher_ia32.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_x64.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/constants_arm.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/constants_ia32.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/constants_x64.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 3 4 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 3 4 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 3 4 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 3 4 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 2 chunks +16 lines, -5 lines 0 comments Download
M runtime/vm/stub_code.h View 1 2 3 4 2 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 2 3 4 4 chunks +29 lines, -21 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 2 3 4 7 chunks +32 lines, -22 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 2 3 4 4 chunks +29 lines, -21 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 2 3 4 5 chunks +29 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
srdjan
7 years, 5 months ago (2013-07-18 20:53:55 UTC) #1
regis
LGTM https://codereview.chromium.org/19774007/diff/25001/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/19774007/diff/25001/runtime/vm/code_generator.cc#newcode1027 runtime/vm/code_generator.cc:1027: // Handles a static call in unoptimized code ...
7 years, 5 months ago (2013-07-18 21:30:18 UTC) #2
srdjan
https://codereview.chromium.org/19774007/diff/25001/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/19774007/diff/25001/runtime/vm/code_generator.cc#newcode1027 runtime/vm/code_generator.cc:1027: // Handles a static call in unoptimized code that ...
7 years, 5 months ago (2013-07-18 22:17:06 UTC) #3
Florian Schneider
Very nice! https://codereview.chromium.org/19774007/diff/2003/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/19774007/diff/2003/runtime/vm/intermediate_language.h#newcode81 runtime/vm/intermediate_language.h:81: V(::, max, MathMax, 1286442186) \ Can you ...
7 years, 5 months ago (2013-07-19 09:21:40 UTC) #4
srdjan
https://codereview.chromium.org/19774007/diff/2003/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/19774007/diff/2003/runtime/vm/intermediate_language.h#newcode81 runtime/vm/intermediate_language.h:81: V(::, max, MathMax, 1286442186) \ On 2013/07/19 09:21:40, Florian ...
7 years, 5 months ago (2013-07-19 16:32:15 UTC) #5
srdjan
7 years, 5 months ago (2013-07-19 16:49:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 manually as r25225 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698