Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 19774003: Bugfix in multitest.dart: Make sure we copy imported files to the generated_tests directory (Closed)

Created:
7 years, 5 months ago by kustermann
Modified:
7 years, 5 months ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Bugfix in multitest.dart: Make sure we copy imported files to the generated_tests directory The regular expression was no longer valid after import statements have changed. Furthermore the guard against cyclic imports was not working because of missing hashCode/operator== on the Path class. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=25155

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M tools/testing/dart/multitest.dart View 1 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 5 months ago (2013-07-18 15:38:08 UTC) #1
ricow1
LGTM, I would consider just calling it foundImports as before https://codereview.chromium.org/19774003/diff/1/tools/testing/dart/multitest.dart File tools/testing/dart/multitest.dart (right): https://codereview.chromium.org/19774003/diff/1/tools/testing/dart/multitest.dart#newcode155 ...
7 years, 5 months ago (2013-07-18 17:07:44 UTC) #2
kustermann
https://codereview.chromium.org/19774003/diff/1/tools/testing/dart/multitest.dart File tools/testing/dart/multitest.dart (right): https://codereview.chromium.org/19774003/diff/1/tools/testing/dart/multitest.dart#newcode155 tools/testing/dart/multitest.dart:155: Set<String> foundImportsAsString = new Set<String>(); On 2013/07/18 17:07:44, ricow1 ...
7 years, 5 months ago (2013-07-18 17:11:27 UTC) #3
kustermann
7 years, 5 months ago (2013-07-18 17:11:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698