Enable coverage tool to handle multiple files and libraries

Enable coverage tool to handle multiple files and libraries

Coverage tool now enables stepping for all libraries with a
url other than "dart:" and "package:"

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25167

[hausner, 2013-07-18 18:40:08]

Sample output when running coverage on multi-library test 
tests/language/library_prefixes_test.dart

$ dart --checked $DART_ROOT/tools/coverage.dart --verbose 
--package-root=$DART_ROOT/xcodebuild/DebugIA32/packages/
tests/language/library_prefixes_test.dart

TARG: Debugger listening on port 62256
Coverage target process (pid 45284) found listening on port 62256.
Debuggee isolate id 7114 created.
Enable stepping for
'file:///src/d2/dart/tests/language/library_prefixes_test.dart'
Enable stepping for 'file:///src/d2/dart/tests/language/library_prefixes.lib'
Enable stepping for
'file:///src/d2/dart/tests/language/library_prefixes_test1.lib'
Enable stepping for
'file:///src/d2/dart/tests/language/library_prefixes_test2.lib'
Debuggee isolate id 7114 shut down.
Sending kill signal to process 45284.
Connection closed by coverage target
Process 45284 terminated with exit code 0.
Coverage info collected from 242 breakpoints:
file:///src/d2/dart/tests/language/library_prefixes.dart
      |// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS
file
      |// for details. All rights reserved. Use of this source code is governed
by a
      |// BSD-style license that can be found in the LICENSE file.
      |
      |part of LibraryPrefixes.lib;
      |
      |class LibraryPrefixes {
      |
      |  static void main(var expectEquals) {
      |    var a = Constants.PI;
      |    var b = other.Constants.PI;
      |    expectEquals(3.14, a);
      |    expectEquals(3.14, b);
      |
      |    expectEquals(1, Constants.foo);
      |    expectEquals(2, other.Constants.foo);
      |
      |    expectEquals(-1, A.y);
      |    expectEquals(0, other.A.y);
      |
     1|    expectEquals(1, new A().x);
     1|    expectEquals(2, new other.A().x);
      |
     1|    expectEquals(3, new A.named().x);
     1|    expectEquals(4, new other.A.named().x);
      |
     1|    expectEquals(3, new A.fac().x);
     1|    expectEquals(4, new other.A.fac().x);
      |
     1|    expectEquals(1, new B().x);
     1|    expectEquals(2, new other.B().x);
      |
     1|    expectEquals(8, new B.named().x);
     1|    expectEquals(13, new other.B.named().x);
      |
     1|    expectEquals(8, new B.fac().x);
     1|    expectEquals(13, new other.B.fac().x);
      |
     1|    expectEquals(1, const C().x);
     1|    expectEquals(2, const other.C().x);
      |
     1|    expectEquals(3, const C.named().x);
     1|    expectEquals(4, const other.C.named().x);
      |
     1|    expectEquals(3, new C.fac().x);
     1|    expectEquals(4, new other.C.fac().x);
      |
     1|    expectEquals(1, const D().x);
     1|    expectEquals(2, const other.D().x);
      |
     1|    expectEquals(8, const D.named().x);
     1|    expectEquals(13, const other.D.named().x);
      |
     1|    expectEquals(8, new D.fac().x);
     1|    expectEquals(13, new other.D.fac().x);
      |
     1|    expectEquals(0, E.foo());
     1|    expectEquals(3, other.E.foo());
      |
     1|    expectEquals(1, new E().bar());
     1|    expectEquals(4, new other.E().bar());
      |
     1|    expectEquals(9, new E().toto(7)());
     1|    expectEquals(16, new other.E().toto(11)());
      |
     1|    expectEquals(111, (new E.fun(100).f)());
     1|    expectEquals(1313, (new other.E.fun(1300).f)());
      |
     1|    expectEquals(999, E.fooo(900)());
     1|    expectEquals(2048, other.E.fooo(1024)());
      |  }
      |}
file:///src/d2/dart/tests/language/library_prefixes_test2.dart
      |// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS
file
      |// for details. All rights reserved. Use of this source code is governed
by a
      |// BSD-style license that can be found in the LICENSE file.
      |
      |part of LibraryPrefixesTest2.lib;
      |
      |class Constants {
      |  static const PI = 3.14;
      |  static const foo = 2;
      |}
      |
      |class A {
      |  static const y = 0;
      |  int x;
     6|  A() : x = 2 {}
     6|  A.named() : x = 4 {}
     6|  A.superC(x) : x = x + 11 {}
     1|  factory A.fac() { return new A.named(); }
      |}
      |
      |class B extends A {
     2|  B() : super() {}
     4|  B.named() : super.superC(2) {}
     1|  factory B.fac() { return new B.named(); }
      |}
      |
      |class C {
      |  final int x;
     6|  const C() : x = 2;
     6|  const C.named() : x = 4;
     6|  const C.superC(x) : x = x + 11;
      |  factory C.fac() { return const C.named(); }
      |}
      |
      |class D extends C {
     2|  const D() : super();
     4|  const D.named() : super.superC(2);
      |  factory D.fac() { return const D.named(); }
      |}
      |
      |class E {
      |  var f;
     6|  E() {}
     3|  E.fun(x) : f = (() { return x + 13; }) {}
      |  static foo() { return 3; }
     1|  static fooo(x) { return () { return x + 1024; }; }
      |  bar() { return 4; }
     1|  toto(x) { return () { return x + 5; }; }
      |}
file:///src/d2/dart/tests/language/library_prefixes_test1.dart
      |// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS
file
      |// for details. All rights reserved. Use of this source code is governed
by a
      |// BSD-style license that can be found in the LICENSE file.
      |
      |part of LibraryPrefixesTest1.lib;
      |
      |class Constants {
      |  static const PI = 3.14;
      |  static const foo = 1;
      |}
      |
      |class A {
      |  static const y = -1;
      |  int x;
     6|  A() : x = 1 {}
     6|  A.named() : x = 3 {}
     6|  A.superC(x) : x = x + 7 {}
     1|  factory A.fac() { return new A.named(); }
      |}
      |
      |class B extends A {
     2|  B() : super() {}
     4|  B.named() : super.superC(1) {}
     1|  factory B.fac() { return new B.named(); }
      |}
      |
      |class C {
      |  final int x;
     6|  const C() : x = 1;
     6|  const C.named() : x = 3;
     6|  const C.superC(x) : x = x + 7;
      |  factory C.fac() { return const C.named(); }
      |}
      |
      |class D extends C {
     2|  const D() : super();
     4|  const D.named() : super.superC(1);
      |  factory D.fac() { return const D.named(); }
      |}
      |
      |class E {
      |  var f;
     6|  E() {}
     3|  E.fun(x) : f = (() { return x + 11; }) {}
      |  static foo() { return 0; }
     1|  static fooo(x) { return () { return x + 99; }; }
      |  bar() { return 1; }
     1|  toto(x) { return () { return x + 2; }; }
      |}
file:///src/d2/dart/tests/language/library_prefixes_test.dart
      |// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS
file
      |// for details. All rights reserved. Use of this source code is governed
by a
      |// BSD-style license that can be found in the LICENSE file.
      |
      |library LibraryPrefixesTest.dart;
      |import "package:expect/expect.dart";
      |import "library_prefixes.lib";
      |
      |class LibraryPrefixesTest {
      |  static testMain() {
    40|    LibraryPrefixes.main((a, b) { Expect.equals(a, b); });
      |  }
      |}
      |
      |main() {
     1|  LibraryPrefixesTest.testMain();
      |}

[srdjan, 2013-07-18 18:51:12]

LGTM

https://codereview.chromium.org/19772004/diff/1/tools/coverage.dart
File tools/coverage.dart (right):

https://codereview.chromium.org/19772004/diff/1/tools/coverage.dart#newcode167
tools/coverage.dart:167: print("Enable stepping for '$url'");
Is that a debugging print?

[hausner, 2013-07-18 19:00:26]

Thank you for the review!

https://codereview.chromium.org/19772004/diff/1/tools/coverage.dart
File tools/coverage.dart (right):

https://codereview.chromium.org/19772004/diff/1/tools/coverage.dart#newcode167
tools/coverage.dart:167: print("Enable stepping for '$url'");
On 2013/07/18 18:51:12, srdjan wrote:
> Is that a debugging print?

I thought it might be a helpful indicator on what the coverage tool is doing,
similar to the "isolate xxx created" messages.

[hausner, 2013-07-18 19:00:45]

Committed patchset #1 manually as r25167 (presubmit successful).