Change how we emit code for Function.apply.

Change how we emit code for Function.apply.

BUG=http://dartbug.com/11993
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25462

[ngeoffray, 2013-07-24 17:40:16]

LGTM!

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1146: ?
computeNamedSelectors(member)
computeNamedSelectors -> computeSeenNamedSelectors ?

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1179: var
properties = [];
List<jsAst.Node> properties = <jsAst.Node>[]

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1192:
r'call$catchAll',
You could also use the namer for that, similar to what we do for the bailout
function. And in the Function.apply method, you could use a foreign helper
JS_GET_CATCH_ALL_NAME().

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/lib...
File dart/sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_helper.dart:574: if (JS('bool', r'"call$catchAll"
in #', function)) {
FYI: JS_GET_CATCH_ALL_NAME.

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_helper.dart:577: // literal.  The keys in the
object literal corresponds to the argument
corresponds -> correspond

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_helper.dart:583: // arguments in [namedArguments],
noSuchMethod will called as expected.
will called -> will be called

[ahe, 2013-07-24 17:54:13]

Good point about using the namer.

I'll address the typos and other nits, submit this CL and follow up with the
namer changes. The way I access getter/setter prefix should be cleaned up at the
same time. I'll try to simplify using namer names at runtime.

[ahe, 2013-07-25 08:51:14]

Thank you, Nicolas.

I'll start working on using the namer right away.

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1146: ?
computeNamedSelectors(member)
On 2013/07/24 17:40:16, ngeoffray wrote:
> computeNamedSelectors -> computeSeenNamedSelectors ?

Done.

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1179: var
properties = [];
On 2013/07/24 17:40:16, ngeoffray wrote:
> List<jsAst.Node> properties = <jsAst.Node>[]

Done.

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1192:
r'call$catchAll',
On 2013/07/24 17:40:16, ngeoffray wrote:
> You could also use the namer for that, similar to what we do for the bailout
> function. And in the Function.apply method, you could use a foreign helper
> JS_GET_CATCH_ALL_NAME().

Added todo.

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/lib...
File dart/sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_helper.dart:574: if (JS('bool', r'"call$catchAll"
in #', function)) {
On 2013/07/24 17:40:16, ngeoffray wrote:
> FYI: JS_GET_CATCH_ALL_NAME.

Added todo.

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_helper.dart:577: // literal.  The keys in the
object literal corresponds to the argument
On 2013/07/24 17:40:16, ngeoffray wrote:
> corresponds -> correspond

Done.

https://codereview.chromium.org/19759008/diff/3001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_helper.dart:583: // arguments in [namedArguments],
noSuchMethod will called as expected.
On 2013/07/24 17:40:16, ngeoffray wrote:
> will called -> will be called

Done.

[ahe, 2013-07-25 09:11:00]

Committed patchset #3 manually as r25462 (presubmit successful).