Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1975493002: Fix all strong-mode warnings. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, Bob Nystrom
Base URL:
git@github.com:dart-lang/shelf_web_socket@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/web_socket_handler.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 7 months ago (2016-05-11 22:19:08 UTC) #1
Jennifer Messerly
lgtm
4 years, 7 months ago (2016-05-11 22:28:39 UTC) #2
nweiz
4 years, 7 months ago (2016-05-11 23:03:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8dde807dc75ab5f93ced5f1e0f48d976b86143a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698