Change "assetIdToUrls" to "pathToUrls" in the pub websocket API.

Change "assetIdToUrls" to "pathToUrls" in the pub websocket API.

This also changes the argument from a URI-formatted path to a native
OS path.

BUG=17146
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34045

[Bob Nystrom, 2014-03-18 17:10:02]

Couple nits, but LGTM.

Are you sure the best way to handle non-entrypoint asset paths is by using
"packages/"? That seems weird if we intend to move away from symlinks.

https://codereview.chromium.org/197533007/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart (right):

https://codereview.chromium.org/197533007/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart:219: /// path relative
to the root of the entrypoint package) for the path being
"root" -> "root directory".

https://codereview.chromium.org/197533007/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart:265: return server.url
+ "/" + path.toUri(relativePath).toString();
Interpolate here.

[nweiz, 2014-03-18 18:20:52]

> Are you sure the best way to handle non-entrypoint asset paths is by using
"packages/"? That seems weird if we intend to move away from symlinks.

I'm almost certain this is the wrong way to handle these paths in the long term.
However, this is how the editor looks up non-entrypoint libraries right now, so
I think this is the best thing in the short term. Doing this right in the long
term will likely require a lot of coordination between pub, the editor, and the
analyzer to avoid relying on symlinks.

https://codereview.chromium.org/197533007/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart (right):

https://codereview.chromium.org/197533007/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart:219: /// path relative
to the root of the entrypoint package) for the path being
On 2014/03/18 17:10:02, Bob Nystrom wrote:
> "root" -> "root directory".

Done.

https://codereview.chromium.org/197533007/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart:265: return server.url
+ "/" + path.toUri(relativePath).toString();
On 2014/03/18 17:10:02, Bob Nystrom wrote:
> Interpolate here.

Done.

[nweiz, 2014-03-18 18:22:21]

Committed patchset #2 manually as r34045 (presubmit successful).