Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 197533004: Adding barback examples. (Closed)

Created:
6 years, 9 months ago by Shams
Modified:
6 years, 8 months ago
Reviewers:
nweiz, Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Incorporating Nathan's feedback #

Total comments: 2

Messages

Total messages: 6 (0 generated)
Shams
Adding the transformer examples to the barback repo. I hope I did this correctly!!
6 years, 9 months ago (2014-03-17 17:37:20 UTC) #1
nweiz
I'd move the files in asset/ to web/, so the user can just run "pub ...
6 years, 9 months ago (2014-03-17 19:48:29 UTC) #2
Shams
Nathan, I have incorporated your feedback. Thanks so much. PTAL!
6 years, 8 months ago (2014-04-08 18:37:56 UTC) #3
nweiz
lgtm https://codereview.chromium.org/197533004/diff/20001/pkg/barback/examples/markdown_converter/README.md File pkg/barback/examples/markdown_converter/README.md (right): https://codereview.chromium.org/197533004/diff/20001/pkg/barback/examples/markdown_converter/README.md#newcode1 pkg/barback/examples/markdown_converter/README.md:1: This example shows how to write a simple ...
6 years, 8 months ago (2014-04-08 21:03:02 UTC) #4
Shams
Committed patchset #2 manually as r34851 (presubmit successful).
6 years, 8 months ago (2014-04-08 23:20:06 UTC) #5
nweiz
6 years, 8 months ago (2014-04-08 23:55:14 UTC) #6
Message was sent while issue was closed.
On 2014/04/08 23:20:06, shaza wrote:
> Committed patchset #2 manually as r34851 (presubmit successful).

I should have caught this earlier, but "examples" should be named "example" to
follow the package layout guidelines.

Powered by Google App Engine
This is Rietveld 408576698