Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 19729005: Fix bot redness. (Closed)

Created:
7 years, 5 months ago by ngeoffray
Modified:
7 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/size_test.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/value_range_test.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
Committed patchset #2 manually as r25149 (presubmit successful).
7 years, 5 months ago (2013-07-18 16:13:40 UTC) #1
ngeoffray
TBR
7 years, 5 months ago (2013-07-18 16:14:04 UTC) #2
karlklose
7 years, 5 months ago (2013-07-18 16:17:13 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698