Avoid flaking in message_extraction tests by doing everything in a temp directory

Avoid flaking in message_extraction tests by doing everything in a temp directory

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34476

[Emily Fortuna, 2014-03-26 17:53:07]

a few nits to look at, but lgtm

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
File pkg/intl/test/message_extraction/failed_extraction_test.dart (right):

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
pkg/intl/test/message_extraction/failed_extraction_test.dart:37: print(allArgs);
debug line?

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
File pkg/intl/test/message_extraction/message_extraction_test.dart (right):

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
pkg/intl/test/message_extraction/message_extraction_test.dart:39: String
inTempDir([String s]) {
maybe call this something like toTempDirPath or something. with a name like
"inTempDir" I expect it to return a boolean testing if something is in a temp
directory. (same for inTestDir)

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
pkg/intl/test/message_extraction/message_extraction_test.dart:114:
previousResult,
this feels like a curious indentation choice to me; I'd be inclined to do:

run(previousResult, 
      [inTestDir(.....)

[Alan Knight, 2014-03-27 17:14:21]

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
File pkg/intl/test/message_extraction/failed_extraction_test.dart (right):

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
pkg/intl/test/message_extraction/failed_extraction_test.dart:37: print(allArgs);
On 2014/03/26 17:53:07, Emily Fortuna wrote:
> debug line?

Oops. Done.

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
File pkg/intl/test/message_extraction/message_extraction_test.dart (right):

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
pkg/intl/test/message_extraction/message_extraction_test.dart:39: String
inTempDir([String s]) {
On 2014/03/26 17:53:07, Emily Fortuna wrote:
> maybe call this something like toTempDirPath or something. with a name like
> "inTempDir" I expect it to return a boolean testing if something is in a temp
> directory. (same for inTestDir)

Done.

https://codereview.chromium.org/197283043/diff/1/pkg/intl/test/message_extrac...
pkg/intl/test/message_extraction/message_extraction_test.dart:114:
previousResult,
On 2014/03/26 17:53:07, Emily Fortuna wrote:
> this feels like a curious indentation choice to me; I'd be inclined to do:
> 
> run(previousResult, 
>       [inTestDir(.....)

Done.

[Alan Knight, 2014-03-27 17:23:26]

Committed patchset #2 manually as r34476 (presubmit successful).

[ricow1, 2014-04-10 13:59:30]

https://codereview.chromium.org/197283043/diff/40001/pkg/intl/test/message_ex...
File pkg/intl/test/message_extraction/message_extraction_test.dart (right):

https://codereview.chromium.org/197283043/diff/40001/pkg/intl/test/message_ex...
pkg/intl/test/message_extraction/message_extraction_test.dart:66: void
deleteGeneratedFiles() {
you don't call this, so this test is now leaving generated stuff in /tmp

[Alan Knight, 2014-04-21 19:14:36]

https://codereview.chromium.org/197283043/diff/40001/pkg/intl/test/message_ex...
File pkg/intl/test/message_extraction/message_extraction_test.dart (right):

https://codereview.chromium.org/197283043/diff/40001/pkg/intl/test/message_ex...
pkg/intl/test/message_extraction/message_extraction_test.dart:66: void
deleteGeneratedFiles() {
On 2014/04/10 13:59:30, ricow1 wrote:
> you don't call this, so this test is now leaving generated stuff in /tmp

Should be fixed now.