Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 197283033: [polymer] fix loader on IE (Closed)

Created:
6 years, 9 months ago by Jennifer Messerly
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M pkg/polymer/lib/src/loader.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
ironic: my use of Object.getPrototypeOf instead of __proto__ was to have better IE compat! :)
6 years, 9 months ago (2014-03-18 23:04:11 UTC) #1
Siggi Cherem (dart-lang)
lgtm
6 years, 9 months ago (2014-03-18 23:07:33 UTC) #2
Jennifer Messerly
Thanks! I changed pubspec to .4 as discussed. Going to publish assuming bots are happy
6 years, 9 months ago (2014-03-18 23:08:33 UTC) #3
Jennifer Messerly
6 years, 9 months ago (2014-03-18 23:08:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r34077 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698