Generate smaller unoptimized code for certain expressions.

Generate smaller unoptimized code for certain expressions.

Code for compound assignments, pre- and post-fix ++, --, cascades in
effect contexts is now smaller by 1 push/pop instructions.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33641

[srdjan, 2014-03-12 18:18:30]

lgtm

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.cc:2065: return (value() != NULL)
InputCount() == 0 seems more readable.

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.cc:2078: ASSERT((value() == NULL) ||
locs()->out().reg() == locs()->in(0).reg());
ditto

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:3438: SetInputAt(0, value);
I think it would be better do add a private method SetValue which would do:
value->set_instruction(this);
value->set_use_index(i)

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:3475: intptr_t num_temps_;
const ?

[Florian Schneider, 2014-03-13 08:56:15]

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.cc:2065: return (value() != NULL)
On 2014/03/12 18:18:30, srdjan wrote:
> InputCount() == 0 seems more readable.

Done.

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.cc:2078: ASSERT((value() == NULL) ||
locs()->out().reg() == locs()->in(0).reg());
On 2014/03/12 18:18:30, srdjan wrote:
> ditto

Done.

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:3438: SetInputAt(0, value);
On 2014/03/12 18:18:30, srdjan wrote:
> I think it would be better do add a private method SetValue which would do:
> value->set_instruction(this);
> value->set_use_index(i)

I would still need RawSetInputAt since it is used by SetInputAt. I'll rather
have  the use-list book-keeping in once place.

https://codereview.chromium.org/197283004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:3475: intptr_t num_temps_;
On 2014/03/12 18:18:30, srdjan wrote:
> const ?

Done.

[Florian Schneider, 2014-03-13 09:07:46]

Committed patchset #2 manually as r33641 (presubmit successful).