Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 197213036: New analyzer snapshot. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove marker #

Total comments: 2

Patch Set 3 : Update pubspec and recent changes. #

Messages

Total messages: 8 (0 generated)
scheglov
6 years, 9 months ago (2014-03-19 22:56:29 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/197213036/diff/20001/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/197213036/diff/20001/pkg/analyzer/pubspec.yaml#newcode2 pkg/analyzer/pubspec.yaml:2: version: 0.13.0-dev.11 I'm fairly sure we need to ...
6 years, 9 months ago (2014-03-19 23:25:38 UTC) #2
scheglov
PTAL https://codereview.chromium.org/197213036/diff/20001/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/197213036/diff/20001/pkg/analyzer/pubspec.yaml#newcode2 pkg/analyzer/pubspec.yaml:2: version: 0.13.0-dev.11 On 2014/03/19 23:25:38, Brian Wilkerson wrote: ...
6 years, 9 months ago (2014-03-20 17:24:51 UTC) #3
blois
lgtm, downstream pubspecs should also be updated with new version.
6 years, 9 months ago (2014-03-20 17:29:01 UTC) #4
Brian Wilkerson
LGTM
6 years, 9 months ago (2014-03-20 17:30:09 UTC) #5
Brian Wilkerson
> downstream pubspecs should also be updated with new version. Wouldn't that be the responsibility ...
6 years, 9 months ago (2014-03-20 17:32:06 UTC) #6
blois
On 2014/03/20 17:32:06, Brian Wilkerson wrote: > > downstream pubspecs should also be updated with ...
6 years, 9 months ago (2014-03-20 17:38:01 UTC) #7
scheglov
6 years, 9 months ago (2014-03-20 17:38:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r34188 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698