Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 19721004: Allow inlining of closures with a context change. (Closed)

Created:
7 years, 5 months ago by Florian Schneider
Modified:
7 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Allow inlining of closures with a context change. This CL removes the remaining missing cases when inlining closure calls. In order to benefit for code using forEach, I added GrowableObjectArray.forEach to the functions that should always be inlined. I also renamed BuildLoadContext/BuildStoreContext helpers in the flow graph builder to better match what they do. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -21 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 14 chunks +12 lines, -16 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +22 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 5 months ago (2013-07-19 13:08:24 UTC) #1
srdjan
lgtm
7 years, 5 months ago (2013-07-19 16:40:34 UTC) #2
Florian Schneider
7 years, 4 months ago (2013-07-29 09:45:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698