Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1971523002: Fix --offline with prerelease versions. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix --offline with prerelease versions. OfflineHostedSource was failing to parse the directory names for prerelease package versions correctly. Closes #1415 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/c54445948b97bdd87d9c6aa3920742e9108198a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M lib/src/source/hosted.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/hosted/offline_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 7 months ago (2016-05-10 20:08:43 UTC) #1
Bob Nystrom
lgtm
4 years, 7 months ago (2016-05-10 20:09:59 UTC) #2
nweiz
4 years, 7 months ago (2016-05-10 20:22:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c54445948b97bdd87d9c6aa3920742e9108198a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698