Issue 19713009: Added part of to Dimension class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19713009: Added part of to Dimension class. (Closed)

Created:
7 years, 5 months ago by Emily Fortuna

Modified:
7 years, 5 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added part of to Dimension class. BUG= Committed: https://code.google.com/p/dart/source/detail?r=25195

Patch Set 1 : #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -0 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/src/Dimension.dart	View	1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Committed patchset #1 manually as r25195 (presubmit successful).

7 years, 5 months ago (2013-07-19 01:08:34 UTC) #2

Jennifer Messerly

7 years, 5 months ago (2013-07-19 01:33:43 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/19713009/diff/2001/tools/dom/src/Dimension.dart
File tools/dom/src/Dimension.dart (right):

https://codereview.chromium.org/19713009/diff/2001/tools/dom/src/Dimension.da...
tools/dom/src/Dimension.dart:1: part of html;
add copyright here? :)

Expand Messages | Collapse Messages