Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 19713002: Allow type objects to be passed in to Dart_GetStaticFields (Closed)

Created:
7 years, 5 months ago by siva
Modified:
7 years, 5 months ago
Reviewers:
hausner, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow type objects to be passed in to Dart_GetStaticFields (This is in sync with the change to have the entire Dart API surface accept type objects instead of exposing the class objects). R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=25137

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M runtime/include/dart_debugger_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 5 months ago (2013-07-18 00:04:37 UTC) #1
Jacob
lgtm
7 years, 5 months ago (2013-07-18 00:06:25 UTC) #2
siva
7 years, 5 months ago (2013-07-18 00:28:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25137 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698