Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 19708003: Catergorized classes to abstract, class, typedef, and error/exception (Closed)

Created:
7 years, 5 months ago by janicejl
Modified:
7 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
Emily Fortuna, Tate Mandel
Visibility:
Public.

Description

Catergorized classes to abstract, class, typedef, and error/exception R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25160

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -20 lines) Patch
M pkg/docgen/lib/docgen.dart View 1 2 3 5 chunks +43 lines, -19 lines 0 comments Download
M pkg/docgen/test/single_library_test.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
janicejl
7 years, 5 months ago (2013-07-18 16:44:22 UTC) #1
Bob Nystrom
Couple of nits then LGTM. https://codereview.chromium.org/19708003/diff/2001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/19708003/diff/2001/pkg/docgen/lib/docgen.dart#newcode390 pkg/docgen/lib/docgen.dart:390: throw new StateError('$mirrorName - ...
7 years, 5 months ago (2013-07-18 17:08:07 UTC) #2
janicejl
7 years, 5 months ago (2013-07-18 17:37:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r25160 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698