Issue 1969953002: Make TreeNode.visit return dynamic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1969953002: Make TreeNode.visit return dynamic. (Closed)

Created:
4 years, 7 months ago by Siggi Cherem (dart-lang)

Modified:
4 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org, terry

Base URL:
git@github.com:dart-lang/csslib.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make TreeNode.visit return dynamic. Subclasses of TreeNode already do `visit(visitor) => visitor.visitSomething(this)`, this just exposes it at the root of the tree hierarchy. This is needed for package:html, where we have code that would do the equivalent of `x = node.visit(myVisitor)`. R=rnystrom@google.com Committed: https://github.com/dart-lang/csslib/commit/a40f8abfe0c475fbc97cd14069f71496ea76552a

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/tree_base.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

4 years, 7 months ago (2016-05-11 23:07:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a40f8abfe0c475fbc97cd14069f71496ea76552a (presubmit successful).