Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 196993003: add sdkPath and enable tests (Closed)

Created:
6 years, 9 months ago by danrubel
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add comments in mock about futures #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -24 lines) Patch
M pkg/analysis_server/lib/src/domain_context.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +96 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_context_test.dart View 3 chunks +11 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 3 chunks +11 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 2 chunks +47 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
6 years, 9 months ago (2014-03-12 13:25:30 UTC) #1
Brian Wilkerson
LGTM
6 years, 9 months ago (2014-03-12 18:42:50 UTC) #2
danrubel
6 years, 9 months ago (2014-03-12 19:18:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r33600 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698