Issue 196983015: Add a [Transform.hasInput] convenience method to Barback.

Issue 196983015: Add a [Transform.hasInput] convenience method to Barback. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a [Transform.hasInput] convenience method to Barback. R=rnystrom@google.com BUG=13264 Committed: https://code.google.com/p/dart/source/detail?r=33724

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -0 lines)			Patch
M	pkg/barback/CHANGELOG.md	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/base_transform.dart	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	pkg/barback/test/package_graph/transform/transform_test.dart	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A	pkg/barback/test/transformer/has_input.dart	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	pkg/barback/test/utils.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/196983015/diff/1/pkg/barback/lib/src/base_transform.dart File pkg/barback/lib/src/base_transform.dart (right): https://codereview.chromium.org/196983015/diff/1/pkg/barback/lib/src/base_transform.dart#newcode116 pkg/barback/lib/src/base_transform.dart:116: /// an [AssetNotFoundException]. Nit: but put the "an" ...

6 years, 9 months ago (2014-03-14 21:07:58 UTC) #2

nweiz

https://codereview.chromium.org/196983015/diff/1/pkg/barback/lib/src/base_transform.dart File pkg/barback/lib/src/base_transform.dart (right): https://codereview.chromium.org/196983015/diff/1/pkg/barback/lib/src/base_transform.dart#newcode116 pkg/barback/lib/src/base_transform.dart:116: /// an [AssetNotFoundException]. On 2014/03/14 21:07:58, Bob Nystrom wrote: ...

6 years, 9 months ago (2014-03-14 21:53:55 UTC) #3

nweiz

6 years, 9 months ago (2014-03-14 21:54:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r33724 (presubmit successful).

Expand Messages | Collapse Messages