pkg/docgen: dir that look like packages, only document the contents of lib

pkg/docgen: dir that look like packages, only document the contents of lib

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33773

[kevmoo, 2014-03-17 20:28:32]

https://codereview.chromium.org/196963003/diff/1/pkg/docgen/lib/src/io.dart
File pkg/docgen/lib/src/io.dart (left):

https://codereview.chromium.org/196963003/diff/1/pkg/docgen/lib/src/io.dart#o...
pkg/docgen/lib/src/io.dart:65: String canonicalize(String pathString) {
We no longer need this special behavior. IO has support for getting the 'real'
path

https://codereview.chromium.org/196963003/diff/1/pkg/docgen/test/generate_jso...
File pkg/docgen/test/generate_json_test.dart (right):

https://codereview.chromium.org/196963003/diff/1/pkg/docgen/test/generate_jso...
pkg/docgen/test/generate_json_test.dart:97: test('exclude non-lib code from
package docs', () {
Ensure that test libs in the docgen package don't show up when documenting the
package.

https://codereview.chromium.org/196963003/diff/1/utils/apidoc/docgen.gyp
File utils/apidoc/docgen.gyp (left):

https://codereview.chromium.org/196963003/diff/1/utils/apidoc/docgen.gyp#oldc...
utils/apidoc/docgen.gyp:88: '--exclude-lib=canonicalization.a',
One less thing to manually manage

[Alan Knight, 2014-03-17 20:37:35]

LGTM, but have you verified that this works correctly on the actual docgen as
done in the build. In particular, I'm thinking of us starting from /pkg and
recursing down into the actual packages, which is potentially different from the
way it's done in the tests, and there's an explicit --package-root.

[kevmoo, 2014-03-17 20:41:03]

On 2014/03/17 20:37:35, Alan Knight wrote:
> LGTM, but have you verified that this works correctly on the actual docgen as
> done in the build. In particular, I'm thinking of us starting from /pkg and
> recursing down into the actual packages, which is potentially different from
the
> way it's done in the tests, and there's an explicit --package-root.

I've verified that this works great with our current setup

[kevmoo, 2014-03-17 20:41:51]

Committed patchset #1 manually as r33773 (presubmit successful).