Issue 19693007: Don't call accept the c socket, if we're currently closing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19693007: Don't call accept the c socket, if we're currently closing. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen

Modified:
7 years, 5 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't call accept the c socket, if we're currently closing. Fixes a crash on Windows. BUG= Committed: https://code.google.com/p/dart/source/detail?r=25226

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	runtime/bin/eventhandler_win.cc	View		1 chunk	+1 line, -1 line	2 comments	Download
	M	runtime/bin/socket_patch.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r25226 (presubmit successful).

7 years, 5 months ago (2013-07-19 16:52:40 UTC) #3

kustermann

lgtm https://codereview.chromium.org/19693007/diff/1/runtime/bin/eventhandler_win.cc File runtime/bin/eventhandler_win.cc (right): https://codereview.chromium.org/19693007/diff/1/runtime/bin/eventhandler_win.cc#newcode327 runtime/bin/eventhandler_win.cc:327: return IsClosing() && !HasPendingRead(); Do we need a ...

7 years, 5 months ago (2013-07-19 16:56:24 UTC) #4

Anders Johnsen

7 years, 5 months ago (2013-07-19 17:03:39 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/19693007/diff/1/runtime/bin/eventhandler_win.cc
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/19693007/diff/1/runtime/bin/eventhandler_win....
runtime/bin/eventhandler_win.cc:327: return IsClosing() && !HasPendingRead();
On 2013/07/19 16:56:24, kustermann wrote:
> Do we need a 'HasPendingWrite()' here as well?

While I convinced myself that FileHandles never works with IOCompletionPorts,
but you are right. Changing.

Expand Messages | Collapse Messages