Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19681002: Add implicit blocks (Closed)

Created:
7 years, 5 months ago by Brian Wilkerson
Modified:
7 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add implicit blocks in 'if', 'do', 'for', and 'while' statements. This is a result of a change in the specification. See issue 11817 for context. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=25123

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -41 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java View 5 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java View 11 chunks +71 lines, -28 lines 2 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
7 years, 5 months ago (2013-07-17 20:37:21 UTC) #1
scheglov
LGTM https://codereview.chromium.org/19681002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java (right): https://codereview.chromium.org/19681002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java#newcode334 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java:334: visitStatementInScope(elseStatement); You could don't check then/else statements for ...
7 years, 5 months ago (2013-07-17 20:53:39 UTC) #2
Brian Wilkerson
https://codereview.chromium.org/19681002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java (right): https://codereview.chromium.org/19681002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java#newcode334 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java:334: visitStatementInScope(elseStatement); Done
7 years, 5 months ago (2013-07-17 20:59:50 UTC) #3
Brian Wilkerson
7 years, 5 months ago (2013-07-17 21:03:59 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r25123 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698