Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 196793014: Add language test for closurization of a closure's call method. (Closed)

Created:
6 years, 9 months ago by rmacnak
Modified:
6 years, 9 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org, Florian Schneider
Visibility:
Public.

Description

Add language test for closurization of a closure's call method. R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=33659

Patch Set 1 #

Total comments: 1

Patch Set 2 : bug numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
A tests/language/call_closurization_test.dart View 1 1 chunk +48 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmacnak
6 years, 9 months ago (2014-03-13 17:21:42 UTC) #1
rmacnak
6 years, 9 months ago (2014-03-13 17:26:52 UTC) #2
gbracha
test lgtm https://codereview.chromium.org/196793014/diff/1/tests/language/call_closurization_test.dart File tests/language/call_closurization_test.dart (right): https://codereview.chromium.org/196793014/diff/1/tests/language/call_closurization_test.dart#newcode16 tests/language/call_closurization_test.dart:16: Expect.isTrue(bar_tearOff.call('foo')); I'd expect to have all cases ...
6 years, 9 months ago (2014-03-13 18:36:35 UTC) #3
rmacnak
On 2014/03/13 18:36:35, gbracha wrote: > test lgtm > > https://codereview.chromium.org/196793014/diff/1/tests/language/call_closurization_test.dart > File tests/language/call_closurization_test.dart (right): ...
6 years, 9 months ago (2014-03-13 18:58:30 UTC) #4
rmacnak
6 years, 9 months ago (2014-03-13 18:59:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r33659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698