Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 19675009: Close 'accepted' sockets when listening socket is closed. Fixes raw_server_socket_cancel_test. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen
Modified:
7 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Close 'accepted' sockets when listening socket is closed. Fixes raw_server_socket_cancel_test. BUG=https://code.google.com/p/dart/issues/detail?id=8675 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25258

Patch Set 1 #

Patch Set 2 : Remove unused Socket.close, #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M runtime/bin/eventhandler_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/raw_server_socket_cancel_test.dart View 1 6 chunks +14 lines, -10 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 5 months ago (2013-07-22 08:30:43 UTC) #1
Søren Gjesse
lgtm
7 years, 5 months ago (2013-07-22 08:54:13 UTC) #2
Anders Johnsen
7 years, 5 months ago (2013-07-22 08:55:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25258 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698