Issue 196723017: Fix polymer tests and a couple bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196723017: Fix polymer tests and a couple bugs (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 9 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix polymer tests and a couple bugs: - Linter tests now check that the output is empty if there are errors - We allow absolute urls when inlining Dart imports - Fix some bugs in tests. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=33679

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -9 lines)			Patch
M	pkg/polymer/lib/src/build/import_inliner.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/polymer/test/build/all_phases_test.dart	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	pkg/polymer/test/build/import_inliner_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/polymer/test/build/linter_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Siggi Cherem (dart-lang)

6 years, 9 months ago (2014-03-14 00:44:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33679 (presubmit successful).