[mdv] getTeminatorAt recurses infinitely if template is its own terminator

[mdv] getTeminatorAt recurses infinitely if template is its own terminator
port of https://github.com/Polymer/mdv/commit/5846863ba6895eaeffee5c4f4618a2f6570c3f99

note that the indicies in that commit are off by 1, it's fixed in a later MDV change and in this port:
https://github.com/Polymer/mdv/commit/83eafb5f2861092fcda56cf28a2570193803fde1, which I have also patched in. Our version was already working but I tweaked the code to more closely resemble the MDV code.

R=justinfagnani@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25363

[Jennifer Messerly, 2013-07-23 03:13:52]

Ping :)

[justinfagnani, 2013-07-23 19:59:40]

lgtm

https://chromiumcodereview.appspot.com/19672018/diff/5001/pkg/mdv/lib/src/tem...
File pkg/mdv/lib/src/template_iterator.dart (right):

https://chromiumcodereview.appspot.com/19672018/diff/5001/pkg/mdv/lib/src/tem...
pkg/mdv/lib/src/template_iterator.dart:235: Node getTerminatorAt(int index) {
for my own education, what's a terminator?

[Jennifer Messerly, 2013-07-23 20:13:00]

https://chromiumcodereview.appspot.com/19672018/diff/5001/pkg/mdv/lib/src/tem...
File pkg/mdv/lib/src/template_iterator.dart (right):

https://chromiumcodereview.appspot.com/19672018/diff/5001/pkg/mdv/lib/src/tem...
pkg/mdv/lib/src/template_iterator.dart:235: Node getTerminatorAt(int index) {
On 2013/07/23 19:59:40, justinfagnani wrote:
> for my own education, what's a terminator?

you know almost as much as I do :)

from the code, each terminator is the last node in the expanded fragment. so if
I assign a 2-item model to: <template
repeat><div>foo</div><div>bar</div><template>, the two "bar" divs will be the
terminators.

[Jennifer Messerly, 2013-07-23 20:21:01]

Committed patchset #3 manually as r25363 (presubmit successful).