Migrate fixnum tests to unittest. Fix int32 rollover bug.

Migrate fixnum tests to unittest. Fix int32 rollover bug.
- Migrated tests to unittest
- Reorganized tests by operator
- Test coverage for +/- overflow/rollover
- Test coverage for null args
- Test coverage for unary -
- Test coverage for comparison operators

BUG=
R=justinfagnani@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25176

[justinfagnani, 2013-07-18 18:27:28]

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/pubspec.yaml
File pkg/fixnum/pubspec.yaml (right):

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/pubspec.yaml#newcode5
pkg/fixnum/pubspec.yaml:5: dependencies:
change this from dependencies: to dev_dependencies:

see http://pub.dartlang.org/doc/pubspec.html

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_32_test.dart
File pkg/fixnum/test/int_32_test.dart (right):

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_32_test.d...
pkg/fixnum/test/int_32_test.dart:91: group("comparison operators", () {
Ideally we want comparison tests that also cover cases where the difference is
in the middle and high order bits. TODO?

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_64_test.dart
File pkg/fixnum/test/int_64_test.dart (right):

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_64_test.d...
pkg/fixnum/test/int_64_test.dart:63: new int64.fromInt(121932631112635269));
int literal is > 53 bits, fails in dart2js

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_64_test.d...
pkg/fixnum/test/int_64_test.dart:477: new int32.fromInt(-2147483648));
only indent 4 spaces

[justinfagnani, 2013-07-18 18:58:56]

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_32_test.dart
File pkg/fixnum/test/int_32_test.dart (right):

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_32_test.d...
pkg/fixnum/test/int_32_test.dart:91: group("comparison operators", () {
On 2013/07/18 18:27:28, justinfagnani wrote:
> Ideally we want comparison tests that also cover cases where the difference is
> in the middle and high order bits. TODO?

oops, I meant this for the 64 bit tests

[Chris Bracken, 2013-07-18 19:06:07]

Also added some min/max edge cases on the comparison operators.

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/pubspec.yaml
File pkg/fixnum/pubspec.yaml (right):

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/pubspec.yaml#newcode5
pkg/fixnum/pubspec.yaml:5: dependencies:
On 2013/07/18 18:27:28, justinfagnani wrote:
> change this from dependencies: to dev_dependencies:
> 
> see http://pub.dartlang.org/doc/pubspec.html

Done.

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_32_test.dart
File pkg/fixnum/test/int_32_test.dart (right):

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_32_test.d...
pkg/fixnum/test/int_32_test.dart:91: group("comparison operators", () {
On 2013/07/18 18:58:56, justinfagnani wrote:
> On 2013/07/18 18:27:28, justinfagnani wrote:
> > Ideally we want comparison tests that also cover cases where the difference
is
> > in the middle and high order bits. TODO?
> 
> oops, I meant this for the 64 bit tests

Done in 64-bit tests.

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_64_test.dart
File pkg/fixnum/test/int_64_test.dart (right):

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_64_test.d...
pkg/fixnum/test/int_64_test.dart:63: new int64.fromInt(121932631112635269));
On 2013/07/18 18:27:28, justinfagnani wrote:
> int literal is > 53 bits, fails in dart2js

Done.

https://codereview.chromium.org/19669002/diff/1/pkg/fixnum/test/int_64_test.d...
pkg/fixnum/test/int_64_test.dart:477: new int32.fromInt(-2147483648));
On 2013/07/18 18:27:28, justinfagnani wrote:
> only indent 4 spaces

Done.

[justinfagnani, 2013-07-18 19:13:47]

https://codereview.chromium.org/19669002/diff/8001/pkg/fixnum/test/int_64_vm_...
File pkg/fixnum/test/int_64_vm_test.dart (right):

https://codereview.chromium.org/19669002/diff/8001/pkg/fixnum/test/int_64_vm_...
pkg/fixnum/test/int_64_vm_test.dart:9: import 'dart:math' as math;
this test is skipped, right? should it just be deleted, or can we make it fast
enough to re-enable

[Chris Bracken, 2013-07-18 19:38:08]

https://codereview.chromium.org/19669002/diff/8001/pkg/fixnum/test/int_64_vm_...
File pkg/fixnum/test/int_64_vm_test.dart (right):

https://codereview.chromium.org/19669002/diff/8001/pkg/fixnum/test/int_64_vm_...
pkg/fixnum/test/int_64_vm_test.dart:9: import 'dart:math' as math;
On 2013/07/18 19:13:48, justinfagnani wrote:
> this test is skipped, right? should it just be deleted, or can we make it fast
> enough to re-enable

Better to replace it with a well-defined set of deterministic tests. Think it
makes more sense to test against expected intx behaviour than blast it with a a
massive set of tests against int behaviour that may or may not test everything
we need to.

Migrated a couple useful tests over to the int32/int64 tests; deleting this
file.

[justinfagnani, 2013-07-18 20:39:34]

lgtm

[Chris Bracken, 2013-07-18 20:45:30]

Committed patchset #6 manually as r25176 (presubmit successful).